-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add job for updating docker images for repository integration-k8s-kind #20
Comments
@edwarnicke What option we can start? |
I forsee some difficulties with Option 1. PRs created by the GITHUB_TOKEN of a cmd-* repo will not have access to any of the secrets of an integration-k8s-* repo. I suspect that means Option 2, unless you have a really clever idea for Option 1 :) As to the branch naming... aren't the branches named in other places update/* ? It might make sense to name the updates integration-k8s-kind/update/${name of repo pushing update} ? Or am I misreading what you mean by %v? |
@edwarnicke
|
Ah... I see where you clearly said that above, what were your thoughts on handling branch proliferation for that? |
@edwarnicke Nice catch :) I think we can just remove the brach in case of updating from SDK right after merge. |
@denis-tingajkin Can we figure out from a merge job which branch it was merged from? |
Description
Each cmd-* application should be able to automatically updating the version of the docker image for
integration-k8s-kind
repository.Solutions
Currently, we have two possible solutions:
cmd-*.
application can create separate PR intointegration-k8s-kind
repository.cmd-*.
application can commit changes of docker image into a special branch. For example, use-case could be next:2.1.
sdk
repo has been updated.2.2.
cmd-*.
repos have been updated.2.3.
cmd-*.
repos provides a commit into branchintegration-k8s-kind/cmd-update-%v
where %v is changed gomod version.Note1: for option2 each commit into branch
integration-k8s-kind/cmd-update-%v
should cancel the previous build on this branch. For this, we can usehttps://github.com/marketplace/actions/cancel-workflow-action#usage
Note2: In case when
cmd-*.
app is updated by the developer's PR then will be created separate PR intointegration-k8s-kind
repo as it prosed in option1.The text was updated successfully, but these errors were encountered: