Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using annotation for all kernel examples #2009

Closed
edwarnicke opened this issue Jul 5, 2021 · 5 comments
Closed

Switch to using annotation for all kernel examples #2009

edwarnicke opened this issue Jul 5, 2021 · 5 comments
Assignees
@Mixaster995
Labels
enhancement New feature or request

Comments

@edwarnicke
Copy link
Member

Please switch all examples to use the annotations instead of just a bare NSC container with an ENV variable patches in.
@denis-tingaikin
Copy link
Member

@edwarnicke It is possible for all kernel examples.
Could you say more about how we can change env to annotation for memif, vfio examples?

@edwarnicke
Copy link
Member Author

kernel examples are sufficient :)

@denis-tingaikin denis-tingaikin changed the title Switch all to using annotation Switch all to using annotation for all kernel examples Jul 5, 2021
@denis-tingaikin
Copy link
Member

OK, now it is clear, thanks!

@denis-tingaikin denis-tingaikin added the enhancement New feature or request label Jul 5, 2021
@denis-tingaikin denis-tingaikin changed the title Switch all to using annotation for all kernel examples Switch to using annotation for all kernel examples Jul 5, 2021
@glazychev-art glazychev-art mentioned this issue Jul 16, 2021
Closed
@glazychev-art
Copy link
Contributor

Improvement in logging required:
networkservicemesh/integration-tests#694

@glazychev-art glazychev-art mentioned this issue Jul 27, 2021
Closed
@Bolodya1997 Bolodya1997 mentioned this issue Oct 4, 2021
Closed
@ThetaDR ThetaDR mentioned this issue Oct 20, 2021
Closed
9 tasks
@Mixaster995 Mixaster995 assigned Mixaster995 and unassigned ThetaDR Nov 9, 2021
@Mixaster995 Mixaster995 mentioned this issue Nov 12, 2021
Merged
@Mixaster995
Copy link
Contributor

closed with #3663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mixaster995 Mixaster995

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@edwarnicke @glazychev-art @Mixaster995 @ThetaDR @denis-tingaikin