Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing arm64 Linux images #9215

Closed
frank7y opened this issue May 29, 2023 · 8 comments · Fixed by networkservicemesh/.github#28
Closed

Missing arm64 Linux images #9215

frank7y opened this issue May 29, 2023 · 8 comments · Fixed by networkservicemesh/.github#28
Assignees
Labels
bug Something isn't working

Comments

@frank7y
Copy link

frank7y commented May 29, 2023

Motivation

Add the possible to compile & run NSM on ARM based machines.

Overview

Hi there,
I noticed that arm64 Linux arch images for many of the NSM images, such as cmd ones, are no longer provided in the latest few versions of NSM. This change has affected, among other things, the possibility to experiment with NSM on Apple Silicon Macs, which is no longer possible. At least not without the hassle of compiling on our own the required images each time. Are there any plans to reintroduce arm64 Linux images in the future?

Thank you for your attention to this matter.

@denis-tingaikin denis-tingaikin added the bug Something isn't working label May 29, 2023
@denis-tingaikin denis-tingaikin self-assigned this May 29, 2023
@denis-tingaikin denis-tingaikin moved this to In Progress in Release v1.10.0 May 29, 2023
@denis-tingaikin
Copy link
Member

denis-tingaikin commented May 29, 2023

@frank7y Thanks for poinitng that. Looks critical.

As I found it comes from https://github.com/docker/build-push-action, looks like behaviour by defualt depending on runner thats why some of our release has this defect.

@edwarnicke I think we might need to specify a list of platforms for releasing images.
Probabbly we could simply start with linux/amd64,linux/arm64
Thoughts?

Also, I think we shoudl re-build all images for all releases that have this defect (should be quicly since we don't need to do changes in code just re-run jobs)

@denis-tingaikin
Copy link
Member

@NikitaSkrynnik This might be useful for building forwarders edwarnicke/govpp#62

@edwarnicke
Copy link
Member

@edwarnicke I think we might need to specify a list of platforms for releasing images.
Probabbly we could simply start with linux/amd64,linux/arm64
Thoughts?

That sounds right to me :)

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Jun 8, 2023

TODO:

sdk->govpp -> cmd-.*-vpp

  • Include nsm/govpp in release pipeline ~ [3h, 4h]
  • Initial CI~ [7h]
  • Consider version format ~ [7h]
  • IUpdate all nsm apps to use nsm/vovpp ~ [7h]

TOTAL: 28h

@edwarnicke
Copy link
Member

TODO:

sdk->govpp -> cmd-.*-vpp

  • Include nsm/govpp in release pipeline ~ [3h, 4h]
  • Initial CI~ [7h]
  • Consider version format ~ [7h]
  • IUpdate all nsm apps to use nsm/vovpp ~ [7h]

TOTAL: 28h

Do we have issues for these other TODOs? Could we link them here?

@glazychev-art
Copy link
Contributor

I think it was closed by mistake

@glazychev-art glazychev-art reopened this Jun 9, 2023
@glazychev-art glazychev-art moved this from Done to In Progress in Release v1.10.0 Jun 9, 2023
@denis-tingaikin
Copy link
Member

@denis-tingaikin
Copy link
Member

Seems like done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
5 participants