-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework of direct memif #373
Comments
@Mixaster995 Is this related to the memifproxy? |
@Mixaster995 Have we gotten to a root cause here? |
@edwarnicke well, not exactly - i've found half-root of this issue: A also added a comment in pr discussion, with details about changes i've made #377. Please, share your thought about this proposed changes. |
Description
I think, it would be good to change current direct memif implementations.
Now there are excessive files creation in case of direct memif, but it causes issue in nse-composition networkservicemesh/deployments-k8s#2381
It might be better to just pass socket url up in chain without taking additional moves.
Current logic
memif_3
created on client side of forwarder on the same file asmemif_4
memif_3
existence and deletingmemif_3
if it's present 3) server-side of forwarder not creatingmemif_2
and just passesmemif_3
file url(same asmemif_4
) up in chain.memif_1
created withmemif_4
socket urlSuggestions
Rework steps 2,3:
memif_3
creation on client-side of forwarder and pass socket url up in chainmemif_3
check and deletion logic on server-side of forwarder and pass url tomemif_1
.The text was updated successfully, but these errors were encountered: