Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPPool doesn't free IP-addresses if healing failed #1007

Closed
glazychev-art opened this issue Jul 6, 2021 · 2 comments
Closed

IPPool doesn't free IP-addresses if healing failed #1007

glazychev-art opened this issue Jul 6, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@glazychev-art
Copy link
Contributor

Current Behavior

This behavior is related to healing.
For example, if local icmp-responder restarted - we start healing from nsmgr.
New icmp-responder receives new request and pulls IP addresses. But if requestTimeout is not enough for icmp-responder, nsmgr will close context with context deadline exceeded error before the request comes back. In this case we will lose allocated IP-addresses

Expected Behavior

Free allocated IP-addresses

Failure Information (for bugs)

For the next request we get:

...
2021-07-02T12:48:48.848275423Z Jul  2 12:48:48.848�[31m [ERRO] [name:nse-kernel-6d67d65dc6-vstxz] �[0m(9.1)           IPPool is empty
...

Steps to Reproduce

  1. Step 1
  2. Step 2
  3. You get the idea...
@denis-tingaikin denis-tingaikin added the bug Something isn't working label Jul 6, 2021
@denis-tingaikin
Copy link
Member

Seems like duplicate of #1020

@glazychev-art
Copy link
Contributor Author

This refers to the previous implementation of healing.
I think this issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants