Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create authorization monitor chain elements #46

Open
edwarnicke opened this issue Jan 20, 2020 · 5 comments
Open

Create authorization monitor chain elements #46

edwarnicke opened this issue Jan 20, 2020 · 5 comments
Assignees

Comments

@edwarnicke
Copy link
Member

edwarnicke commented Jan 20, 2020

This is a followup for after #45.

We will also need authorization chain elements for connection.MonitorNetworkServiceServer and connection.MonitorNetworkServiceClient.

Please put them in the pkg/connection/common subdir (as they are part of the connection API).

@edwarnicke
Copy link
Member Author

Depends on #48

@denis-tingaikin
Copy link
Member

@edwarnicke This is looking good to go. Can we schedule this for 1.4.0?

@anastasia-malysheva
Copy link
Contributor

anastasia-malysheva commented Jun 10, 2022

@edwarnicke
This is a proposal on the task, please take a look:

  1. Add next chain element for monitor server/client
  2. Next authorization politics for servers are proposed:
    2.1. NSC: every client can monitor only it's own connections.
    2.2. Forwarder: every forwarder can monitor only it's own connections to NSE and nsmgr-proxy.
    2.3. nsmgr: every nsmgr can monitor only it's own connections. Other managers can't monitor others managers' connections.
    2.4. nsmgr-proxy: every nsmgr-proxy can monitor only it's own connections.
    2.5. NSE: every NSE can monitor only it's own connections with nsmgr.

@anastasia-malysheva
Copy link
Contributor

@edwarnicke
This is updated proposal on the task, please take a look:

  1. Add next chain element for monitor server/client
  2. Authorization politic for all servers is: every server can monitor only it's own connections.

@edwarnicke
Copy link
Member Author

@edwarnicke This is updated proposal on the task, please take a look:

  1. Add next chain element for monitor server/client

That sounds like the right approach

  1. Authorization politic for all servers is: every server can monitor only it's own connections.

That sounds like the right default policy. Do make sure we have an easy way to inject a different OPA policy as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants