Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: Extended Connection/NSE labels #490

Closed
Bolodya1997 opened this issue Sep 28, 2020 · 3 comments
Closed

Spec: Extended Connection/NSE labels #490

Bolodya1997 opened this issue Sep 28, 2020 · 3 comments

Comments

@Bolodya1997
Copy link

To select NSE client uses network service name and labels. Now there is only one selector for labels:

  • exact match
request: {
    Labels: map[string]string{
        "value": "10",
    }
}

nse: {
    Labels: map[string]string{
        "value": "10",
    }
}

A proposal is to add extra selectors:

  1. set selectors - value is a comma separated set of values:
  • one of
request: {
    Labels: map[string]string{
        "node": "one-of:a,b,c",
    }
}

nse: {
    Labels: map[string]string{
        "node": "a",
    }
}
  • contains
request: {
    Labels: map[string]string{
        "typesSupported": "contains:b,c",
    }
}

nse: {
    Labels: map[string]string{
        "typesSupported": "a,b,c,d",
    }
}
  1. comparison selectors - value is a number:
  • lower than
request: {
    Labels: map[string]string{
        "latency": "lower-than:100",
    }
}

nse: {
    Labels: map[string]string{
        "latency": "40",
    }
}
  • greater than
request: {
    Labels: map[string]string{
        "capability": "greater-than:100",
    }
}

nse: {
    Labels: map[string]string{
        "capability": "500",
    }
}
@denis-tingaikin
Copy link
Member

Sounds a little bit like networkservicemesh/api#51

@edwarnicke
Copy link
Member

Do we have a current use case you have in mind for this?

@Bolodya1997
Copy link
Author

Guess it is really a duplicate, closing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants