Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possible to pkg sandbox to be usable in docker tests #740

Open
denis-tingaikin opened this issue Feb 26, 2021 · 2 comments
Open

Add possible to pkg sandbox to be usable in docker tests #740

denis-tingaikin opened this issue Feb 26, 2021 · 2 comments
Assignees
Labels
blocked Something is blocking this enhancement New feature or request

Comments

@denis-tingaikin
Copy link
Member

Description

Currently many and many cmd-apps doing the same setup for registry memory or for emulating manager in each test that making reading and supporting tests difficult.

Examples:

  1. https://github.com/networkservicemesh/cmd-nsmgr/blob/master/test/client_endpoint_test.go#L64-L192
  2. https://github.com/networkservicemesh/cmd-nse-icmp-responder/blob/master/suite_setup_test.go#L103-L152
  3. https://github.com/networkservicemesh/cmd-forwarder-vpp/blob/master/internal/tests/suite_setup_test.go#L121-L191

Solution

  1. Add possible to sandbox pass additional dial options to use transport creds with spire cert.
  2. Use sandbox around the testing application.
@denis-tingaikin denis-tingaikin added the enhancement New feature or request label Feb 26, 2021
@denis-tingaikin
Copy link
Member Author

@edwarnicke Is this make sense?

@Bolodya1997
Copy link

Bolodya1997 commented Apr 27, 2021

Blocked by #870.

@Bolodya1997 Bolodya1997 removed the blocked Something is blocking this label May 6, 2021
@denis-tingaikin denis-tingaikin added the blocked Something is blocking this label Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Something is blocking this enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants