-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use clock library to enhance testing #764
Labels
Comments
@edwarnicke Can we go with this? This can speed up our unit tests. This problem is most actual for #650 where we have long tests to check functionality based on timers. |
Merged
@denis-tingaikin I had a long talk with @Bolodya1997 about this... and am fully in support :) |
Merged
Linked PRs:
|
Blocker for #823. |
@Bolodya1997 Is this still in progress? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue
We are running all our unit tests on multiple platforms with
--race
flag. It does mean that any timeout test becomes either slow or not stable or both, because we have totally no idea how long could it take for something to happen.Solution
Instead of using timeouts in tests we can use some clock library (e.g. https://github.com/benbjohnson/clock) to use mocked time in tests and real time in applications.
The text was updated successfully, but these errors were encountered: