Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanup chain element #1246

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

glazychev-art
Copy link
Contributor

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

This PR adds new chain element that cleans up resources on chainCtx.Done()

Issue link

Issue: networkservicemesh/sdk-vpp#516

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
type Option func(*options)

// WithCCClose - closes clientconn to prevent calling requests/closes on other datapath objects
func WithCCClose() Option {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this to something readable?

Suggested change
func WithCCClose() Option {
func WithLocalClose() Option {

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit b88289b into networkservicemesh:main Mar 16, 2022
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1246

Commit: b88289b
Author: Artem Glazychev
Date: 2022-03-16 17:50:41 +0700
Message:
  - Add cleanup chain element (#1246)
* Add cleanup chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Rename option

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1246

Commit: b88289b
Author: Artem Glazychev
Date: 2022-03-16 17:50:41 +0700
Message:
  - Add cleanup chain element (#1246)
* Add cleanup chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Rename option

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1246

Commit: b88289b
Author: Artem Glazychev
Date: 2022-03-16 17:50:41 +0700
Message:
  - Add cleanup chain element (#1246)
* Add cleanup chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Rename option

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1246

Commit: b88289b
Author: Artem Glazychev
Date: 2022-03-16 17:50:41 +0700
Message:
  - Add cleanup chain element (#1246)
* Add cleanup chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Rename option

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1246

Commit: b88289b
Author: Artem Glazychev
Date: 2022-03-16 17:50:41 +0700
Message:
  - Add cleanup chain element (#1246)
* Add cleanup chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Rename option

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1246

Commit: b88289b
Author: Artem Glazychev
Date: 2022-03-16 17:50:41 +0700
Message:
  - Add cleanup chain element (#1246)
* Add cleanup chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Rename option

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1246

Commit: b88289b
Author: Artem Glazychev
Date: 2022-03-16 17:50:41 +0700
Message:
  - Add cleanup chain element (#1246)
* Add cleanup chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Rename option

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1246

Commit: b88289b
Author: Artem Glazychev
Date: 2022-03-16 17:50:41 +0700
Message:
  - Add cleanup chain element (#1246)
* Add cleanup chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Rename option

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1246

Commit: b88289b
Author: Artem Glazychev
Date: 2022-03-16 17:50:41 +0700
Message:
  - Add cleanup chain element (#1246)
* Add cleanup chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Rename option

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Mar 16, 2022
…k@main

PR link: networkservicemesh/sdk#1246

Commit: b88289b
Author: Artem Glazychev
Date: 2022-03-16 17:50:41 +0700
Message:
  - Add cleanup chain element (#1246)
* Add cleanup chain element

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Rename option

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants