-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving is_training_set_available
in sys_info
during get_overall_statistics()
#453
Comments
@OscarWang114 Thanks for reporting the issue! First, could I also agree with having more specific control around feature groups (in this case, train-only or not). Is the flag name just |
@odashi Thanks! Yes, |
Although this issue occurs in the web interface. I'm writing it here as it's mainly SDK-related.
Problem
In the web interface:
In SDK:
The function
_gen_cases_and_stats()
inconditional_generation.py
(called byprocessor.py
’sget_overall_statistics()
) skips savingrequire_training_set=True
example-level features. However, these skipped feature names are saved insys_info.analysis_levels[0]
.This causes
perform()
inBucketAnalysis
inanalyses.py
to attempt to look up these features and throw the above error as the features cannot be found in the actual cases (since they are skipped).Quick fix
Set
skip_failed_analyses=True
.Long-term solution
Following up on #410, we should save a flag like
is_training_set_available
insys_info
. If set to false, we should skip therequire_training_set=True
features during bucket analysis.The text was updated successfully, but these errors were encountered: