Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Analysis Todo List #500

Open
qjiang002 opened this issue Sep 21, 2022 · 1 comment
Open

Custom Analysis Todo List #500

qjiang002 opened this issue Sep 21, 2022 · 1 comment

Comments

@qjiang002
Copy link
Collaborator

Custom features

Now users can specify custom features in either the output json file or a global config file. Potential improvements are:

  • Only json output file can support defining custom features and custom analysis, and tsv file cannot. For consistency, it may be better to separate the custom analysis settings from the output file and put them into a json config file.
  • Support uploading custom analysis config file.

Custom functions

[unsupported] we also aim to allow users to specify feature function so that the analysis could be performed more flexibly.

@odashi
Copy link
Contributor

odashi commented Sep 24, 2022

@qjiang002 Good point. Moreover, the FileLoaderMetadata mechanism reads the entire output file to load the metadata, which is obviously redundant. Decoupling the metadata file from the output may also improve this efficiency.

def from_file(cls, file_name: str) -> FileLoaderMetadata:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants