Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cls pooling option #565

Closed
davidmezzetti opened this issue Sep 25, 2023 · 1 comment
Closed

Add cls pooling option #565

davidmezzetti opened this issue Sep 25, 2023 · 1 comment
Assignees
@davidmezzetti
Milestone
v6.2.0

Comments

@davidmezzetti
Copy link
Member

davidmezzetti commented Sep 25, 2023 •
edited
Loading

Currently, txtai has mean pooling built in. Other pooling options require using the sentence-transformers library. This issue will add cls pooling to txtai like mean pooling.

Ensure concepts mentioned in #535 and #536 are properly handled.
@davidmezzetti davidmezzetti added this to the v6.2.0 milestone Sep 25, 2023
@davidmezzetti davidmezzetti self-assigned this Sep 25, 2023
This was referenced Sep 25, 2023
Closed
Closed
@davidmezzetti davidmezzetti changed the title Add class pooling option Add cls pooling option Oct 5, 2023
@davidmezzetti
Copy link
Member Author

This fix also added support for CLS pooling to ONNX exports. But adding int32 conversions is not a part of it given that HF Tokenizers return int64 arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidmezzetti davidmezzetti

Labels
None yet
Projects
None yet
Milestone
v6.2.0
Development

No branches or pull requests
1 participant
@davidmezzetti