Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with calling cached_file for local directories #825

Closed
davidmezzetti opened this issue Dec 1, 2024 · 0 comments
Closed

Fix issue with calling cached_file for local directories #825

davidmezzetti opened this issue Dec 1, 2024 · 0 comments
Assignees
@davidmezzetti
Labels
bug Something isn't working
Milestone
v8.1.0

Comments

@davidmezzetti
Copy link
Member

There are multiple cases in the codebase where cached_file is called. It correctly handles a remote repository not having a file but the behavior of that method is different when working with local directories. It returns None.

This return value should be handled properly.
@davidmezzetti davidmezzetti added the bug Something isn't working label Dec 1, 2024
@davidmezzetti davidmezzetti added this to the v8.1.0 milestone Dec 1, 2024
@davidmezzetti davidmezzetti self-assigned this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidmezzetti davidmezzetti

Labels
bug Something isn't working
Projects
None yet
Milestone
v8.1.0
Development

No branches or pull requests
1 participant
@davidmezzetti