Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Commit 5abb0c8

Browse files
KuntaiDuRobert Shaw
authored andcommitted
[CI] Avoid naming different metrics with the same name in performance benchmark (vllm-project#5615)
1 parent f691b45 commit 5abb0c8

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

.buildkite/nightly-benchmarks/scripts/convert-results-json-to-markdown.py

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515
"avg_latency": "Mean latency (ms)",
1616
# "P10": "P10 (s)",
1717
# "P25": "P25 (s)",
18-
"P50": "Median",
18+
"P50": "Median latency (ms)",
1919
# "P75": "P75 (s)",
2020
# "P90": "P90 (s)",
21-
"P99": "P99",
21+
"P99": "P99 latency (ms)",
2222
}
2323

2424
# throughput tests and the keys that will be printed into markdown
@@ -43,15 +43,14 @@
4343
# "input_throughput": "Input Tput (tok/s)",
4444
# "output_throughput": "Output Tput (tok/s)",
4545
"mean_ttft_ms": "Mean TTFT (ms)",
46-
# do not say TTFT again to avoid the table getting too wide
47-
"median_ttft_ms": "Median",
48-
"p99_ttft_ms": "P99",
46+
"median_ttft_ms": "Median TTFT (ms)",
47+
"p99_ttft_ms": "P99 TTFT (ms)",
4948
# "mean_tpot_ms": "Mean TPOT (ms)",
5049
# "median_tpot_ms": "Median",
5150
# "p99_tpot_ms": "P99",
5251
"mean_itl_ms": "Mean ITL (ms)",
53-
"median_itl_ms": "Median",
54-
"p99_itl_ms": "P99",
52+
"median_itl_ms": "Median ITL (ms)",
53+
"p99_itl_ms": "P99 ITL (ms)",
5554
}
5655

5756

@@ -183,3 +182,11 @@ def results_to_json(latency, throughput, serving):
183182
serving_tests_markdown_table=serving_md_table,
184183
benchmarking_results_in_json_string=processed_results_json)
185184
f.write(results)
185+
186+
# document benchmarking results in json
187+
with open(results_folder / "benchmark_results.json", "w") as f:
188+
189+
results = latency_results.to_dict(
190+
orient='records') + throughput_results.to_dict(
191+
orient='records') + serving_results.to_dict(orient='records')
192+
f.write(json.dumps(results))

0 commit comments

Comments
 (0)