Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hh.mod for CoreNEURON compatibility changes hh.mod in place during build #3000

Open
mgeplf opened this issue Jul 17, 2024 · 3 comments
Labels

Comments

@mgeplf
Copy link
Collaborator

mgeplf commented Jul 17, 2024

Context

Overview of the issue

When CoreNEURON is enabled in build, the hh.mod file gets updated in place, which means it's easy to check it in by accident.

Expected result/behavior

If changes to mod files are needed, the should probably be done in a separate directly that isn't tracked by source control.

NEURON setup

  • Version: master branch

Minimal working example - MWE

  • CMake build commands:
mkdir build && cd build
cmake -DNRN_ENABLE_CORENEURON=ON  ..
cmake --build . --
@mgeplf mgeplf added the bug label Jul 17, 2024
@mgeplf
Copy link
Collaborator Author

mgeplf commented Jul 17, 2024

This is directed by this:
https://github.com/neuronsimulator/nrn/blob/master/CMakeLists.txt#L747

Not sure what the best course of action is.

@JCGoran
Copy link
Contributor

JCGoran commented Aug 15, 2024

Could the mod files first be copied to some temp dir, and then compiled? IIRC, nrnivmodl doesn't care where the mod files themselves are, since the compiled files will be placed in $PWD/<arch> anyway.

@mgeplf
Copy link
Collaborator Author

mgeplf commented Aug 15, 2024

I haven't looked too deaply at it, but I think that's true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants