Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review refcounting in NpySObj_contains. #3020

Open
1uc opened this issue Jul 30, 2024 · 0 comments
Open

Review refcounting in NpySObj_contains. #3020

1uc opened this issue Jul 30, 2024 · 0 comments

Comments

@1uc
Copy link
Collaborator

1uc commented Jul 30, 2024 •
edited
Loading

Thanks to @mgeplf for noticing that the ref count for obj isn't sharp:

nrn/src/nrnpython/nrnpy_nrn.cpp

Line 198 in ddf1bee

auto _pyobj = nb::borrow(obj); // keep refcount+1 during use

See the following comment on #3018:
#3018 (comment)

The task is to carefully review the ref counting for this function and confirm if there's an issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@1uc