Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect tn in token #164

Open
di-shi opened this issue Jan 24, 2023 · 3 comments
Open

Incorrect tn in token #164

di-shi opened this issue Jan 24, 2023 · 3 comments

Comments

@di-shi
Copy link

di-shi commented Jan 24, 2023

When dest tn is "sip:14045266060@example.com", the test bed puts "114045266060" in token. If the test bed rejects the request, it is fine. But put a wrong tn in token is an issue. Same for orig tn.

Test on 1/24/2023.

@kpolitz
Copy link
Contributor

kpolitz commented Feb 9, 2023

Acknowledged if the leading "+" is not there. Will review with development relative to expected / valid SIP URI format(s) for TNs.

@kpolitz
Copy link
Contributor

kpolitz commented Feb 16, 2023

Acknowledged and change and / or clarification of the "uri" parameter will be available in next pull request. A note will be sent to test participants when change is available. Ideally, clients should be sending telephone numbers in "uri" in global context. If they are limited, then a server implementation could allow other options.

@kpolitz
Copy link
Contributor

kpolitz commented Mar 13, 2023

These changes and clarifications were deployed on 2/23/23. Please test and confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants