Skip to content
This repository was archived by the owner on Feb 18, 2024. It is now read-only.

Commit 9ceebe7

Browse files
authored
Update to ESLint 5 (#1025)
* Updates all dependencies to the latest available to pick up any ESLint 5 compatibility fixes (in the case of `babel-eslint` and `eslint-plugin-vue` this meant beta versions, so for those the tilde range has been changed to exact, pending the final versions). * Raises `ecmaVersion` to `2018`. * Removes all custom `ecmaFeatures` options since: - `impliedStrict` is redundant when using `sourceType: 'module'` - none of the others are recognised by latest ESLint/`babel-eslint` Migration guide: https://eslint.org/docs/user-guide/migrating-to-5.0.0 Docs to help with reviewing the `parserOptions` changes: https://eslint.org/docs/user-guide/configuring#specifying-parser-options https://github.com/babel/babel-eslint#configuration https://eslint.org/docs/rules/strict#rule-details (for `impliedStrict`) Fixes #383. Closes #963. Closes #1001.
1 parent e683e37 commit 9ceebe7

File tree

12 files changed

+249
-371
lines changed

12 files changed

+249
-371
lines changed

package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@
3636
"devDependencies": {
3737
"auto-changelog": "^1.4.6",
3838
"ava": "^1.0.0-beta.4",
39-
"eslint": "^4.19.1",
40-
"eslint-config-prettier": "^3.0.0",
41-
"eslint-plugin-prettier": "^2.6.0",
39+
"eslint": "^5.4.0",
40+
"eslint-config-prettier": "^3.0.1",
41+
"eslint-plugin-prettier": "^2.6.2",
4242
"husky": "^0.14.3",
4343
"jest": "^23.0.0",
4444
"karma": "^3.0.0",

packages/airbnb-base/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@
2424
},
2525
"dependencies": {
2626
"@neutrinojs/eslint": "9.0.0-0",
27-
"eslint-config-airbnb-base": "^13.0.0",
28-
"eslint-plugin-import": "^2.12.0"
27+
"eslint-config-airbnb-base": "^13.1.0",
28+
"eslint-plugin-import": "^2.14.0"
2929
},
3030
"peerDependencies": {
31-
"eslint": "^4.0.0",
31+
"eslint": "^5.0.0",
3232
"neutrino": "^9.0.0-0",
3333
"webpack": "^4.0.0"
3434
}

packages/airbnb/package.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@
2424
},
2525
"dependencies": {
2626
"@neutrinojs/eslint": "9.0.0-0",
27-
"eslint-config-airbnb": "^17.0.0",
28-
"eslint-config-airbnb-base": "^13.0.0",
29-
"eslint-plugin-import": "^2.12.0",
30-
"eslint-plugin-jsx-a11y": "^6.0.3",
31-
"eslint-plugin-react": "^7.9.1"
27+
"eslint-config-airbnb": "^17.1.0",
28+
"eslint-config-airbnb-base": "^13.1.0",
29+
"eslint-plugin-import": "^2.14.0",
30+
"eslint-plugin-jsx-a11y": "^6.1.1",
31+
"eslint-plugin-react": "^7.11.1"
3232
},
3333
"peerDependencies": {
34-
"eslint": "^4.0.0",
34+
"eslint": "^5.0.0",
3535
"neutrino": "^9.0.0-0",
3636
"webpack": "^4.0.0"
3737
}

packages/create-project/commands/init/matrix.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const AIRBNB = '@neutrinojs/airbnb';
1717
const AIRBNB_BASE = '@neutrinojs/airbnb-base';
1818
const STANDARDJS = '@neutrinojs/standardjs';
1919

20-
const ESLINT = 'eslint@^4';
20+
const ESLINT = 'eslint@^5';
2121
const WEBPACK = 'webpack@^4';
2222
const WEBPACK_CLI = 'webpack-cli@^2';
2323
const WEBPACK_DEV_SERVER = 'webpack-dev-server@^3';

packages/eslint/README.md

+2-7
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,8 @@ neutrino.use(eslint, {
5252
envs: ['es6'],
5353
parser: 'babel-eslint',
5454
parserOptions: {
55-
ecmaVersion: 2017,
56-
sourceType: 'module',
57-
ecmaFeatures: {
58-
objectLiteralDuplicateProperties: false,
59-
generators: true,
60-
impliedStrict: true
61-
}
55+
ecmaVersion: 2018,
56+
sourceType: 'module'
6257
},
6358
settings: {},
6459
globals: ['process'],

packages/eslint/index.js

+2-7
Original file line numberDiff line numberDiff line change
@@ -98,13 +98,8 @@ module.exports = (neutrino, opts = {}) => {
9898
envs: ['es6'],
9999
parser: require.resolve('babel-eslint'),
100100
parserOptions: {
101-
ecmaVersion: 2017,
102-
sourceType: 'module',
103-
ecmaFeatures: {
104-
objectLiteralDuplicateProperties: false,
105-
generators: true,
106-
impliedStrict: true
107-
}
101+
ecmaVersion: 2018,
102+
sourceType: 'module'
108103
},
109104
settings: {},
110105
globals: ['process'],

packages/eslint/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,16 @@
2323
"yarn": ">=1.2.1"
2424
},
2525
"dependencies": {
26-
"babel-eslint": "^8.2.3",
26+
"babel-eslint": "9.0.0-beta.3",
2727
"debug": "^3.1.0",
2828
"deepmerge": "^1.5.2",
29-
"eslint-loader": "^2.0.0",
29+
"eslint-loader": "^2.1.0",
3030
"eslint-plugin-babel": "^5.1.0",
3131
"lodash.clonedeep": "^4.5.0",
3232
"lodash.omit": "^4.5.0"
3333
},
3434
"peerDependencies": {
35-
"eslint": "^4.0.0",
35+
"eslint": "^5.0.0",
3636
"neutrino": "^9.0.0-0",
3737
"webpack": "^4.0.0"
3838
}

packages/jest/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"@neutrinojs/compile-loader": "9.0.0-0",
2828
"@neutrinojs/loader-merge": "9.0.0-0",
2929
"babel-plugin-jest-hoist": "^23.0.0",
30-
"eslint-plugin-jest": "^21.15.1",
30+
"eslint-plugin-jest": "^21.21.0",
3131
"lodash.omit": "^4.5.0"
3232
},
3333
"peerDependencies": {

packages/react/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"@neutrinojs/loader-merge": "9.0.0-0",
3232
"@neutrinojs/web": "9.0.0-0",
3333
"deepmerge": "^1.5.2",
34-
"eslint-plugin-react": "^7.9.1"
34+
"eslint-plugin-react": "^7.11.1"
3535
},
3636
"devDependencies": {
3737
"react": "*",

packages/standardjs/package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@
2727
"@neutrinojs/eslint": "9.0.0-0",
2828
"eslint-config-standard": "^11.0.0",
2929
"eslint-config-standard-jsx": "^5.0.0",
30-
"eslint-plugin-import": "^2.12.0",
31-
"eslint-plugin-node": "^6.0.1",
30+
"eslint-plugin-import": "^2.14.0",
31+
"eslint-plugin-node": "^7.0.1",
3232
"eslint-plugin-promise": "^4.0.0",
33-
"eslint-plugin-react": "^7.9.1",
33+
"eslint-plugin-react": "^7.11.1",
3434
"eslint-plugin-standard": "^3.1.0"
3535
},
3636
"peerDependencies": {
37-
"eslint": "^4.0.0",
37+
"eslint": "^5.0.0",
3838
"neutrino": "^9.0.0-0"
3939
}
4040
}

packages/vue/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
"@neutrinojs/web": "9.0.0-0",
2626
"css-loader": "^1.0.0",
2727
"deepmerge": "^1.5.2",
28-
"eslint-plugin-react": "^7.9.1",
29-
"eslint-plugin-vue": "^4.5.0",
28+
"eslint-plugin-react": "^7.11.1",
29+
"eslint-plugin-vue": "5.0.0-beta.3",
3030
"stylelint-processor-html": "^1.0.0",
3131
"vue-loader": "^15.0.0",
3232
"vue-style-loader": "^4.1.0",

0 commit comments

Comments
 (0)