Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Remove process.exit(0) on run. #118

Closed
jaridmargolin opened this issue Mar 15, 2017 · 1 comment
Closed

Remove process.exit(0) on run. #118

jaridmargolin opened this issue Mar 15, 2017 · 1 comment

Comments

@jaridmargolin
Copy link
Contributor

jaridmargolin commented Mar 15, 2017

  api[command](args)
    .then(() => process.exit(0))
    .catch(err => {
      if (err) {
        console.error(err);
      }

      process.exit(1);
    });

I am curious as to why .then(() => process.exit(0)) needs to be chained off of the api command. As long as the catch does not hit, the process will already exit with a 0, correct?

This also has consequences of stopping execution of various plugins. For example BundleAnalyzer executes after webpack has compiled.

@eliperelman
Copy link
Member

Resolved in #119.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants