Environment-specific configs silently not working after #852

[edmorley]

With Neutrino 8 it was possible to define environment specific configs, like so:

module.exports = {
  use: [
    '@neutrinojs/web',
  ],
  env: {
    FOO: {
      bar: {
        use: ['some_other_preset'],
      },
    },
  },
};

...and then 'some_other_preset' would be activated when doing either:

1. FOO=bar neutrino <command>
2. neutrino <command> --options.env.FOO bar

After #852, option (2) no longer exists (which is unavoidable), however (1) no longer causes the preset to be loaded - meaning this feature can no longer be used.

[eliperelman]

This was intended, should we label this docs for migration?

[edmorley]

Even (1)?

[edmorley]

Presumably the recommended way now would be to do:

module.exports = {
  use: [
    '@neutrinojs/web',
    (neutrino) => {
      if (process.env.FOO === 'bar') {
        neutrino.use('some_other_preset');
      }
    },
  ],
};

...or alternatively:

module.exports = {
  use: [
    '@neutrinojs/web',
    process.env.FOO === 'bar' ? 'some_other_preset' : false,
  ],
};

[edmorley]

If removal of this feature is intentional, I think we should add a check for env and fail loudly if it's passed, to ensure behaviour doesn't silently change.

[eliperelman]

Agreed, and yes, I believe it was intentional on both points.