Downloading sdkv4

[paologallinaharbur]

SDKv4 has been released but we had issues importing it

$go get github.com/newrelic/infra-integrations-sdk/v4@v4.0.0
go get github.com/newrelic/infra-integrations-sdk/v4@v4.0.0: github.com/newrelic/infra-integrations-sdk@v4.0.0: invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v4

$go get github.com/newrelic/infra-integrations-sdk@v4.0.0
go get github.com/newrelic/infra-integrations-sdk@v4.0.0: github.com/newrelic/infra-integrations-sdk@v4.0.0: invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v4

If I run simply $go get github.com/newrelic/infra-integrations-sdk I get version:
github.com/newrelic/infra-integrations-sdk v3.6.5+incompatible // indirect

Should we add in the go.mod the version of the package?
something like this

golang/go#35732 (comment)

[carlosroman]

So we did something bad and delete the old V4 tag as realised that the way go mod was implemented was in correct. We recreated the tag with a fix added to it. You now have to use go get github.com/newrelic/infra-integrations-sdk/v4.

[carlosroman]

But yes, fix was to add the version to the package as you can see from the PR #252.

[paologallinaharbur]

Awesome thanks, we can close the issue I believe

[paologallinaharbur]

$ go get github.com/newrelic/infra-integrations-sdk/v4
go: github.com/newrelic/infra-integrations-sdk/v4 upgrade => v4.0.0