Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exclude data url requests as captured AJAX events #1012

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

cwli24
Copy link
Contributor

@cwli24 cwli24 commented May 3, 2024

Do not report XMLHttpRequest or fetch calls made for data urls. The event and metric created for data urls are sparse and unhelpful, so they are no longer being captured or sent.

Overview

For data urls, no ajax event will be created and no xhr timeslice added. This strips out pointless events with domains of undefined:undefined and timeslice metrics with host of the same.

Related Issue(s)

bug - https://new-relic.atlassian.net/browse/NR-220129
test conv - https://new-relic.atlassian.net/browse/NR-136610

Testing

Copy link

github-actions bot commented May 3, 2024

Static Badge

Last ran on May 03, 2024 22:45:19 CDT
Checking merge of (65b05e2) into main (44f229e)

Copy link

github-actions bot commented May 3, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 31.38 kB / 10.99 kB (gzip) 31.38 kB / 10.99 kB (gzip) 0% / 0% (gzip)
lite async-chunk 50.97 kB / 16.58 kB (gzip) 50.97 kB / 16.58 kB (gzip) 0% / 0% (gzip)
pro loader 51.23 kB / 17.39 kB (gzip) 52.11 kB / 17.68 kB (gzip) 1.71% / 1.64% (gzip)
pro async-chunk 94.22 kB / 28.69 kB (gzip) 93.52 kB / 28.47 kB (gzip) -0.74% / -0.77% (gzip)
spa loader 59.14 kB / 19.82 kB (gzip) 60.02 kB / 20.1 kB (gzip) 1.48% / 1.39% (gzip)
spa async-chunk 109.28 kB / 33.1 kB (gzip) 108.52 kB / 32.86 kB (gzip) -0.7% / -0.72% (gzip)
lite-polyfills loader 125.19 kB / 40.25 kB (gzip) 125.19 kB / 40.25 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 65.77 kB / 18.96 kB (gzip) 65.77 kB / 18.96 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 145.27 kB / 46.22 kB (gzip) 147.25 kB / 46.57 kB (gzip) 1.37% / 0.75% (gzip)
pro-polyfills async-chunk 129.66 kB / 33.88 kB (gzip) 127.9 kB / 33.38 kB (gzip) -1.36% / -1.46% (gzip)
spa-polyfills loader 153.25 kB / 48.36 kB (gzip) 155.24 kB / 48.68 kB (gzip) 1.29% / 0.67% (gzip)
spa-polyfills async-chunk 146.48 kB / 38.26 kB (gzip) 144.62 kB / 37.98 kB (gzip) -1.27% / -0.73% (gzip)

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.58%. Comparing base (44f229e) to head (65b05e2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1012      +/-   ##
==========================================
- Coverage   86.64%   86.58%   -0.06%     
==========================================
  Files         154      154              
  Lines        7126     7124       -2     
  Branches     1414     1416       +2     
==========================================
- Hits         6174     6168       -6     
- Misses        829      830       +1     
- Partials      123      126       +3     
Flag Coverage Δ
integration-tests 90.77% <100.00%> (+0.04%) ⬆️
unit-tests 74.06% <90.90%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwli24 cwli24 merged commit 2a3fa57 into main May 6, 2024
50 of 51 checks passed
@cwli24 cwli24 deleted the block-data-url branch May 6, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants