fix: Updated Logging API function #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Logging API wrapper function to call the logging method
|
|
|
Thanks for opening this PR @mikecit22 . Please sign the CLA and we can get this into the next release. |
|
Sure thing I just signed it |
patrickhousley
changed the title
patrickhousley
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where the logging API method would always result in an uninitialized agent warning and would not capture the log.
Overview
When configuring and using the new Logging feature it always warns that it's not initialized. I am able to get it to work if I change logInfo to log.
Related Issue(s)
Testing
Tested it locally and now I am seeing logging in my NR dashboard
