-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct naming for logging pageUrl attribute #1225
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
==========================================
- Coverage 88.43% 88.42% -0.01%
==========================================
Files 169 169
Lines 7365 7363 -2
Branches 1507 1507
==========================================
- Hits 6513 6511 -2
Misses 726 726
Partials 126 126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Corrects naming for the Logging pageUrl attribute by using the original url of the page instead of the url of when the event happens. Removes origin attribute from the runtime model object.
Overview
Corrects the naming for the Logging
pageUrl
attribute by using the original url of the page instead of the url of when the event happens. The original url of the page is also referred to asinitialLocation
. A test has been added to check that thepageUrl
attribute in the Log object isinitialLocation
.Removes origin attribute from the runtime model object by cleaning up usage of
runtime.origin
in spa feature. TheinitialLocation
constant is a direct replacement for it.These changes are for cleaning up the agent code.
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-320541
Testing
Make sure tests pass. Agent should work identically to before except that the
pageUrl
for logging events is now corrected to the original URL.