fix: Fix syntax error in fallback when tracking xhr readyState

[metal-messiah]

A syntax error was introduced that would cause xhr readystate fallback checks to always capture.

Overview

Contributor @steve-cunnew found an issue in the code base where a typo was introduced. This likely was not noticed because it was nearly always truthy, leading to expected behavior. This affects an edge case.

Related Issue(s)

https://newrelic.slack.com/archives/C0193KAHHAS/p1733483033474939

Testing

Tests should continue to pass

[github-actions]

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent	Asset	Previous Size	New Size	Diff
lite	loader	29.39 kB / 10.68 kB (gzip)	29.39 kB / 10.68 kB (gzip)	0% / 0% (gzip)
lite	async-chunk	53.39 kB / 17.35 kB (gzip)	53.39 kB / 17.35 kB (gzip)	0% / 0% (gzip)
pro	loader	50.83 kB / 17.54 kB (gzip)	50.83 kB / 17.53 kB (gzip)	0% / -0.02% (gzip)
pro	async-chunk	101.43 kB / 30.9 kB (gzip)	101.43 kB / 30.9 kB (gzip)	0% / 0% (gzip)
spa	loader	58.41 kB / 19.86 kB (gzip)	58.4 kB / 19.86 kB (gzip)	0% / -0.02% (gzip)
spa	async-chunk	116.15 kB / 35.18 kB (gzip)	116.15 kB / 35.18 kB (gzip)	0% / 0% (gzip)

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.03%. Comparing base (560a957) to head (22127ae).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/features/ajax/instrument/index.js	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1272   +/-   ##
=======================================
  Coverage   89.03%   89.03%           
=======================================
  Files         170      170           
  Lines        7396     7396           
  Branches     1489     1489           
=======================================
  Hits         6585     6585           
  Misses        690      690           
  Partials      121      121           

Flag	Coverage Δ
integration-tests	91.62% <ø> (+0.02%)	⬆️
unit-tests	79.60% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Last ran on December 09, 2024 18:48:16 CST
Checking merge of (22127ae) into main (560a957)