Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Report config changes away from default state for UX improvement #885

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Feb 10, 2024

Detect if the default config values have been altered at runtime. This is useful to evaluate what the reasonable defaults are across a customer base over time to provide a better UX.

Overview

This PR also contains a change to the SR init to align the defaults to the UI and API, of 10% and 100%

Related Issue(s)

Testing

Copy link

github-actions bot commented Feb 10, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.59 kB / 10.68 kB (gzip) 30.6 kB / 10.68 kB (gzip) 0% / 0.01% (gzip)
lite async-chunk 45.89 kB / 15.11 kB (gzip) 45.89 kB / 15.11 kB (gzip) 0% / 0% (gzip)
pro loader 49.42 kB / 16.82 kB (gzip) 49.42 kB / 16.82 kB (gzip) 0% / 0.01% (gzip)
pro async-chunk 74.79 kB / 23.61 kB (gzip) 75.54 kB / 23.79 kB (gzip) 1.01% / 0.78% (gzip)
spa loader 55.9 kB / 18.8 kB (gzip) 55.9 kB / 18.8 kB (gzip) 0% / 0.02% (gzip)
spa async-chunk 89.55 kB / 28 kB (gzip) 90.31 kB / 28.19 kB (gzip) 0.85% / 0.69% (gzip)
lite-polyfills loader 125.21 kB / 39.94 kB (gzip) 125.22 kB / 39.94 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 58.25 kB / 17.21 kB (gzip) 58.25 kB / 17.21 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 144.96 kB / 45.75 kB (gzip) 144.96 kB / 45.75 kB (gzip) 0% / 0% (gzip)
pro-polyfills async-chunk 101.82 kB / 27.59 kB (gzip) 101.82 kB / 27.59 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 152.98 kB / 47.9 kB (gzip) 152.98 kB / 47.9 kB (gzip) 0% / 0% (gzip)
spa-polyfills async-chunk 117.38 kB / 32.56 kB (gzip) 117.38 kB / 32.56 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (697f13e) 79.05% compared to head (1fb91e3) 79.08%.

Files Patch % Lines
src/features/session_replay/aggregate/index.js 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
+ Coverage   79.05%   79.08%   +0.03%     
==========================================
  Files         145      145              
  Lines        6535     6545      +10     
  Branches     1269     1276       +7     
==========================================
+ Hits         5166     5176      +10     
  Misses       1158     1158              
  Partials      211      211              
Flag Coverage Δ
integration-tests 89.33% <90.90%> (+0.01%) ⬆️
unit-tests 55.50% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 10, 2024

Static Badge

Last ran on February 10, 2024 15:51:35 CST
Checking merge of (1fb91e3) into main (697f13e)

@metal-messiah metal-messiah changed the title feat: Report config changes away from default state for observability purposes feat: Report config changes away from default state for UX improvement Feb 12, 2024
@metal-messiah metal-messiah merged commit aa19a9c into main Feb 12, 2024
50 of 53 checks passed
@metal-messiah metal-messiah deleted the sr-configs-sms branch February 12, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants