Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Preload the Session Replay recorder when properly configured #893

Merged
merged 11 commits into from
Mar 5, 2024

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Feb 14, 2024

Load the Session Replay recorder module before the page load when configured to do so. This will increase visibility for recordable data for customers who have opted in to the behavior.

Overview

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-222367
https://new-relic.atlassian.net/browse/NR-232242

Testing

A new test has been added to validate that the agent will record before the page load event when properly configured -- session_replay.preload

Copy link

github-actions bot commented Feb 14, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.61 kB / 10.69 kB (gzip) 31.96 kB / 11.09 kB (gzip) 4.4% / 3.66% (gzip)
lite async-chunk 45.89 kB / 15.11 kB (gzip) 45.89 kB / 15.09 kB (gzip) 0.01% / -0.11% (gzip)
pro loader 49.51 kB / 16.88 kB (gzip) 50.99 kB / 17.27 kB (gzip) 2.98% / 2.3% (gzip)
pro async-chunk 75.62 kB / 23.79 kB (gzip) 75.62 kB / 23.8 kB (gzip) 0% / 0.01% (gzip)
spa loader 55.99 kB / 18.86 kB (gzip) 57.54 kB / 19.23 kB (gzip) 2.77% / 2% (gzip)
spa async-chunk 90.4 kB / 28.19 kB (gzip) 90.4 kB / 28.19 kB (gzip) 0% / 0% (gzip)
lite-polyfills loader 125.22 kB / 39.95 kB (gzip) 127.44 kB / 40.55 kB (gzip) 1.77% / 1.5% (gzip)
lite-polyfills async-chunk 58.26 kB / 17.21 kB (gzip) 58.28 kB / 17.2 kB (gzip) 0.03% / -0.06% (gzip)
pro-polyfills loader 145.04 kB / 45.8 kB (gzip) 147.34 kB / 46.44 kB (gzip) 1.58% / 1.38% (gzip)
pro-polyfills async-chunk 101.84 kB / 27.59 kB (gzip) 101.83 kB / 27.59 kB (gzip) 0% / -0.01% (gzip)
spa-polyfills loader 153.07 kB / 47.95 kB (gzip) 155.47 kB / 48.57 kB (gzip) 1.57% / 1.3% (gzip)
spa-polyfills async-chunk 117.39 kB / 32.57 kB (gzip) 117.39 kB / 32.56 kB (gzip) 0% / -0.02% (gzip)

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: Patch coverage is 89.18919% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 78.88%. Comparing base (85887c8) to head (bbfc55f).

Files Patch % Lines
src/features/session_replay/aggregate/index.js 87.14% 6 Missing and 3 partials ⚠️
src/loaders/agent-base.js 0.00% 2 Missing ⚠️
src/loaders/api/api.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
+ Coverage   78.86%   78.88%   +0.01%     
==========================================
  Files         147      148       +1     
  Lines        6583     6606      +23     
  Branches     1289     1294       +5     
==========================================
+ Hits         5192     5211      +19     
- Misses       1175     1179       +4     
  Partials      216      216              
Flag Coverage Δ
integration-tests 89.18% <93.93%> (-0.01%) ⬇️
unit-tests 55.66% <82.14%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 14, 2024

Static Badge

Last ran on March 05, 2024 13:32:09 CST
Checking merge of (bbfc55f) into main (85887c8)

@metal-messiah metal-messiah merged commit bc5ebb5 into main Mar 5, 2024
51 checks passed
@metal-messiah metal-messiah deleted the sr-preload branch March 5, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants