-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove webpack imports in npm package #925
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
+ Coverage 80.51% 80.56% +0.04%
==========================================
Files 154 154
Lines 7057 7058 +1
Branches 1397 1400 +3
==========================================
+ Hits 5682 5686 +4
+ Misses 1171 1168 -3
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e96f091
to
ab29644
Compare
ab29644
to
0e1a128
Compare
Transitioning certain module imports so that the default import is for the npm version of the module instead of the cdn or webpack version. This should completely eliminate all references to webpack globals when using the npm package.
Overview
Transitioned the import overrides from babel to webpack. The default imports for
env
,nonce
, andpublic-path
will not be the npm "version" of the module. Only during the webpack build will the imports for these modules be changed to import the cdn "version".Related Issue(s)
https://new-relic.atlassian.net/browse/NR-234606
Closes #902
Testing
dist
directory should have no files containing__webpack
.<blah>.cdn
files in the chrome dev tools.