Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apiaccess): fix to the error thrown when API Access Key creation fails #1015

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

pranav-new-relic
Copy link
Member

@pranav-new-relic pranav-new-relic commented Mar 30, 2023

Description

This PR addresses NR-97066, comprising

  • Fixes and refactoring to methods and structures in the apiaccess package to fix irregular errors thrown in the event of create/update/delete API Access Keys, addition of formatting to thee errors and test cases to validate the same
  • Refactoring the error thrown - Error: json: cannot unmarshal object into Go struct field .data.apiAccessCreateKeys.errors of type apiaccess.APIAccessKeyErrorInterface when create/update operations are performed on API Access Keys to fix the issues listed below

Fixes

  • #1418 in the Terraform Provider
  • #2261 in the Terraform Provider

@newrelic newrelic deleted a comment from CLAassistant Mar 30, 2023
@newrelic newrelic deleted a comment from codecov-commenter Mar 30, 2023
@newrelic newrelic deleted a comment from CLAassistant Mar 30, 2023
@newrelic newrelic deleted a comment from codecov-commenter Mar 30, 2023
@pranav-new-relic pranav-new-relic force-pushed the np/NR-97066 branch 4 times, most recently from 7bbb9bb to f614d14 Compare March 31, 2023 07:36
@newrelic newrelic deleted a comment from codecov-commenter Mar 31, 2023
@pranav-new-relic pranav-new-relic force-pushed the np/NR-97066 branch 3 times, most recently from 3b52f31 to 3d15a4c Compare April 2, 2023 18:32
@newrelic newrelic deleted a comment from codecov-commenter Apr 3, 2023
@pranav-new-relic pranav-new-relic marked this pull request as ready for review April 3, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants