chore(cloud): update to queries, types to support azure monitor integration from TF #1029
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1029 +/- ##
==========================================
+ Coverage 40.79% 41.62% +0.82%
==========================================
Files 79 79
Lines 4956 4956
==========================================
+ Hits 2022 2063 +41
+ Misses 2788 2745 -43
- Partials 146 148 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pranav-new-relic
force-pushed
the
feat/azure-monitor
branch
2 times, most recently
from
e8a8cec
to
688cee2
Compare
| type CloudAwsGovcloudLinkAccountInput struct { | ||
| // The key used to make requests to AWS service APIs | ||
| AccessKeyId string `json:"accessKeyId"` | ||
| // The AWS account id | ||
| AwsAccountId string `json:"awsAccountId"` | ||
| // How metrics will be collected. | ||
| MetricCollectionMode CloudMetricCollectionMode `json:"metricCollectionMode,omitempty"` | ||
| // The linked account name. | ||
| Name string `json:"name"` | ||
| // The secret key used to make requests to AWS service APIs | ||
| SecretAccessKey SecureValue `json:"secretAccessKey"` | ||
| } | ||
|
|
There was a problem hiding this comment.
A note for the reviewer: changes show this type to have been deleted, as it has been replaced by CloudAwsGov**C**loudLinkAccountInput (since the C in 'Govcloud' was made a capital letter in the NerdGraph API, we see a change in the type via Tutone). Types with similar names also show similar changes in this file.
pranav-new-relic
force-pushed
the
feat/azure-monitor
branch
2 times, most recently
from
1ca227a
to
8c36920
Compare
pranav-new-relic
changed the title
pranav-new-relic
force-pushed
the
feat/azure-monitor
branch
from
f6b20fc
to
6a5d639
Compare
This PR addresses NR-110266, go-client changes to facilitate the addition of a new Azure integration
azureMonitorto Terraform, and comprises the following -cloudConfigureIntegrationand its counterpart to disable cloud integrationsazureMonitorintegration is created/updated/deleted as expectedIntegration Test Results
Unit Test Results
Note
The integration test added in this PR will probably not function (see results in Git Integration Tests) since the variables needed to link an Azure account to New Relic (i.e. Azure account credentials) are not present in the environment running these tests. However, this has been tested locally, and the following screenshots show the results.
The integration test succeeds when a valid Azure account linked to New Relic is provided.
The integration test fails if an invalid Azure account (that does not exist and is not linked to New Relic) is provided.