Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(destinations): expose destination guid #1096

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

nzur-newrelic
Copy link
Contributor

@nzur-newrelic nzur-newrelic commented Feb 21, 2024

Expose destination entity GUID through the client

@pranav-new-relic
Copy link
Member

Looks good to me @nzur-newrelic - verified all guid fields added to the create, update mutations and the get query map to the datatypes using the GUID type added to the types. Shall wait for the tests to run 👍

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.90%. Comparing base (7f26352) to head (5697bb4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1096   +/-   ##
=======================================
  Coverage   38.90%   38.90%           
=======================================
  Files          86       86           
  Lines        5590     5590           
=======================================
  Hits         2175     2175           
  Misses       3249     3249           
  Partials      166      166           
Flag Coverage Δ
unit 38.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pranav-new-relic
Copy link
Member

All checks passed 👍 @nzur-newrelic let me know if this is good to merge (once you take one final look at these changes too).

@pranav-new-relic pranav-new-relic merged commit 0e011a0 into newrelic:main Feb 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants