Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboards): Added ignore time picker as options field to the dashboard variables #1106

Merged
merged 17 commits into from
Mar 15, 2024

Conversation

Avinash-Sanpala
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (5d3232e) to head (eaba3e9).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1106       +/-   ##
===========================================
+ Coverage   38.90%   68.83%   +29.92%     
===========================================
  Files          86      104       +18     
  Lines        5590     6341      +751     
===========================================
+ Hits         2175     4365     +2190     
+ Misses       3249     1643     -1606     
- Partials      166      333      +167     
Flag Coverage Δ
integration 60.91% <ø> (?)
unit 38.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pranav-new-relic pranav-new-relic force-pushed the avi/NR-170831-add-options-to-dashboard-variables branch from 8f811be to 106c96a Compare March 8, 2024 06:03
@pranav-new-relic pranav-new-relic force-pushed the avi/NR-170831-add-options-to-dashboard-variables branch from 106c96a to 003db7e Compare March 8, 2024 06:04
chore: update obsolete GUID to fix more failing tests
@pranav-new-relic pranav-new-relic force-pushed the avi/NR-170831-add-options-to-dashboard-variables branch from 27fdb01 to ac1ee0b Compare March 8, 2024 06:42
@pranav-new-relic
Copy link
Member

pranav-new-relic commented Mar 8, 2024

(8 March, 2024): attaching this screenshot for future reference

image

https://github.com/newrelic/newrelic-client-go/actions/runs/8199765206/job/22425371395?pr=1106

@pranav-new-relic pranav-new-relic force-pushed the avi/NR-170831-add-options-to-dashboard-variables branch from 937430d to e9c1e64 Compare March 11, 2024 04:25
@Avinash-Sanpala Avinash-Sanpala merged commit 228db82 into main Mar 15, 2024
9 of 10 checks passed
@Avinash-Sanpala Avinash-Sanpala deleted the avi/NR-170831-add-options-to-dashboard-variables branch March 15, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants