feat(destinations): add custom header auth and secureUrl to destinations #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranav-new-relic
changed the title
pranav-new-relic
changed the title
nzur-newrelic
changed the title
pranav-new-relic
changed the title
|
@nzur-newrelic these changes look good to me - I've just left a comment and a question. However, let us not merge this PR until the Terraform changes for this are drafted and everything looks good on the Terraform front as well - I mention this, since we've made a lot of pointer and omitempty changes, which are usually a bit fragile. Please let me know once you're done with these changes as well, after which we shall proceed with the remainder of this PR. |
pranav-new-relic
force-pushed
the
add-custom-header-auth
branch
4 times, most recently
from
9fc45c5
to
124acb2
Compare
IliaShurygin
approved these changes
Apr 15, 2024
pranav-new-relic
force-pushed
the
add-custom-header-auth
branch
from
124acb2
to
3c69240
Compare
8 tasks
pranav-new-relic
approved these changes
Apr 16, 2024
pranav-new-relic
force-pushed
the
add-custom-header-auth
branch
from
3c69240
to
e7ac42c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Maintainers
This PR adds 2 new changes to destinations schema:
Required by newrelic/terraform-provider-newrelic#2635