feat(synthetics): Added support for Synthetics Multi Browser, Multi Devices attributes in few synthetics APIs #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashank-reddy-nr
changed the title
shashank-reddy-nr
force-pushed
the
NR-293403
branch
from
f01f8da
to
ba0ab28
Compare
shashank-reddy-nr
force-pushed
the
NR-293403
branch
from
31563b3
to
d214012
Compare
…synthetics monitors
shashank-reddy-nr
force-pushed
the
NR-293403
branch
from
d214012
to
a331fd8
Compare
LGTM |
pranav-new-relic
approved these changes
Sep 10, 2024
|
we might need to convert the []s to *[]s later on probably, when the API supports accepting an empty list (to remove browsers and devices) |
|
Agree, we will do this whenever required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Recently, Synthetics added a new feature for scripted, step, and simple browser monitors to support multiple browsers and devices, allowing users to choose from various options when running monitors. Until now, we only had the option of choosing one device combination. As per customer requests and Synthetics' requirements to support the same multi-browser/devices functionality in Terraform, So, support terraform changes we need changes in client-go as well. So, made below changes to support this.
Changes
1: Ran tutone and generated synthetics package, which brought browsers, devices fileds.
2: Added integration test cases to validate browsers, devices fields.
3: Sross checked the changes tutone brought in and tested the changes related to these fields along with integration test cases as well.