Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerous errors in Netty instrumentation when using GRPC #2177

Open
dhilpipre opened this issue Dec 18, 2024 · 1 comment
Open

Numerous errors in Netty instrumentation when using GRPC #2177

dhilpipre opened this issue Dec 18, 2024 · 1 comment
Labels
bug Something isn't working as designed/intended

Comments

@dhilpipre
Copy link
Contributor

Description

The Netty instrumentation for Netty 4.1.16 includes reading inbound headers on Http2. When GRPC is being used, there are numerous errors being logged to the agent log at a high rate. If logging level is set to FINER or FINEST the logs were fill up very fast. These errors are caused by the fact that the GRPC Http2 header class expects an io.netty.util.AsciiString input and the agent is passing a String object.

In order to get rid of all the error log, it is necessary to put in a check for GRPC and if it is GRPC then create an AsciiString from the String and pass the AsciiString to GRPC.

I have coded this already and will generate a pull request referring back to this bug.

@dhilpipre dhilpipre added the bug Something isn't working as designed/intended label Dec 18, 2024
@workato-integration
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as designed/intended
Projects
None yet
Development

No branches or pull requests

1 participant