Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Limit depenendencies #321

Merged
merged 1 commit into from
Sep 10, 2024
Merged

chore: Limit depenendencies #321

merged 1 commit into from
Sep 10, 2024

Conversation

jsumners-nr
Copy link
Contributor

Express has released new majors as of 2024-09-09. This PR fixes an issue where the latest version of body-parser causes a test failure. It also pins graphql-tag to avoid any potential similar issue in the future.

https://github.com/newrelic/node-newrelic/actions/runs/10791757204/job/29929879809?pr=2553

Express has released new majors as of 2024-09-09. This PR fixes an issue where the latest version of `body-parser` causes a test failure. It also pins `graphql-tag` to avoid any potential similar issue in the future.

https://github.com/newrelic/node-newrelic/actions/runs/10791757204/job/29929879809?pr=2553
@jsumners-nr jsumners-nr marked this pull request as ready for review September 10, 2024 11:57
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (4becfe1) to head (e45d814).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #321   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files           7        7           
  Lines         891      891           
=======================================
  Hits          882      882           
  Misses          9        9           
Flag Coverage Δ
integration-tests-18.x 93.93% <ø> (ø)
integration-tests-20.x 93.93% <ø> (ø)
integration-tests-22.x 93.93% <ø> (ø)
unit-tests-18.x 59.70% <ø> (ø)
unit-tests-20.x 59.70% <ø> (ø)
unit-tests-22.x 59.70% <ø> (ø)
versioned-tests-18.x 95.84% <ø> (ø)
versioned-tests-20.x 95.84% <ø> (ø)
versioned-tests-22.x 95.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 added the dev:tests Indicates only updates to tests label Sep 10, 2024
@jsumners-nr jsumners-nr merged commit 66e9008 into main Sep 10, 2024
40 checks passed
@jsumners-nr jsumners-nr deleted the jsumners-nr-patch-1 branch September 10, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only updates to tests
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

2 participants