Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Explore PHP 8.1 Build System Changes #271

Closed
2 tasks done
mfulb opened this issue Oct 29, 2021 · 3 comments
Closed
2 tasks done

[PHP] Explore PHP 8.1 Build System Changes #271

mfulb opened this issue Oct 29, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@mfulb
Copy link
Contributor

mfulb commented Oct 29, 2021

The goal is to explore the implications of any build system changes with PHP 8.1 and determine any needed implementation tasks (ideally with scope and time estimates).

Find and explore areas of change enough to get an idea of the scope of any work and then document the effort in the implementation MMF/issue tickets.

Changes are documented here: UPGRADING.INTERNALS.

Part of #258.

Acceptance Tasks:

  • Investigate PHP 8.1 RC5 and record findings
  • Investigate PHP 8.1 RC6 and record findings
@mfulb mfulb added the bug Something isn't working label Oct 29, 2021
@mfulb mfulb added this to the PHP 8.1 Support milestone Oct 29, 2021
@mfulb
Copy link
Contributor Author

mfulb commented Nov 1, 2021

When upgrading the prototype to use RC4 it was noticed the following warning was issued when the PHP build ran the "configure" script:

configure: WARNING: unrecognized options: --enable-zip, --without-libzip, --enable-maintainer-zts

Upon investigation it was found:

  • since libzip is no longer bundled with the PHP sources as of PHP 7.4 the "--enable-zip" and "--without-libzip" options are no longer accepted and the proper way to enable support is now to use "--with-zip".
  • the "--enable-maintainer-zts" option has been renamed top "--enable-zts" as of PHP 8.0.

The php build scripts used internally have been updated to reflect these changes.

@mfulb mfulb self-assigned this Nov 3, 2021
@mfulb
Copy link
Contributor Author

mfulb commented Nov 3, 2021

Reviewed RC5 - main change is "-Wimplicit-fallthrough=1" is now default for compilers which support the option.
This change affects how PHP itself is compiled and not the agent itself.
The agent uses "-Wextra" which includes "-Wimplicit-fallthrough".

@mfulb
Copy link
Contributor Author

mfulb commented Nov 15, 2021

No new changes with RC6 release.

@mfulb mfulb closed this as completed Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant