Redis Cluster causes instrumentation error

[jdelStrother]

Description

I noticed this in my newrelic_agent.log:

[2024-08-15 14:11:05 +0000 app1-1 (690412)] ERROR : Error while installing redis_instrumentation instrumentation:
[2024-08-15 14:11:05 +0000 app1-1 (690412)] ERROR : LocalJumpError: unexpected return

I'm guessing this is due to the return here -

newrelic-ruby-agent/lib/new_relic/agent/instrumentation/redis.rb

Lines 33 to 49 in 4c5c8db

	executes do
	NewRelic::Agent.logger.info('Installing Redis Instrumentation')
	if NewRelic::Agent::Instrumentation::Redis::Constants::HAS_REDIS_CLIENT
	RedisClient.register(NewRelic::Agent::Instrumentation::RedisClient::Middleware)
	if defined?(Redis::Cluster::Client)
	return RedisClient.register(NewRelic::Agent::Instrumentation::RedisClient::ClusterMiddleware)
	end
	end
	if use_prepend?
	prepend_instrument Redis::Client, NewRelic::Agent::Instrumentation::Redis::Prepend
	else
	chain_instrument NewRelic::Agent::Instrumentation::Redis::Chain
	end
	end
	end

which is invalid outside of a method

[workato-integration]

https://new-relic.atlassian.net/browse/NR-303263

[fallwith]

Hi @jdelStrother. Thanks very much for the report and hypothesized synopsis which seems spot on to me. We'll take a look.

[fallwith]

Hi @jdelStrother. A fix for this bug has hit our dev branch and will be available in the next agent release. Thanks for your help.