-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node 22 testing #2171
Comments
Please see #2164 For what it's worth, Node 22 will not be labeled as LTS by upstream until October of 2024. Until then, it is not recommended to use Node 22 for production systems. |
@kibertoad based on our initial CI runs this will be a rather clean upgrade for our agent. However, it is not on our roadmap for at least a quarter. As @jsumners-nr said, we only support LTS versions and we have a few months until 22 is in LTS. |
Linking internal doc that's tracking CI runs |
@bizob2828 What are the implications for that if we decide to run 22 in production, other than "Don't complain about things being broken if you use it"? I remember older New Relic versions warning about "Not adding native metric sampler" about Node 20, which I assume had negative perf impact (see #1712). Will same thing happen for Node 22 now? |
@kibertoad we do not support running the agent in production with Node 22 until it is LTS. |
@bizob2828 Yes, but what does "we do not support" mean? Does that mean that it might work, but if it doesn't then New Relic won't address the issues (which is fair), or is it already known up-front that there will be certain issues? |
@kibertoad "we do not support" means we aren't sure what works and what doesn't. It's use at your own risk and don't reach out to us if you have problems 😄 . So we recommend to not use Node 22 with New Relic Node.js agent until we officially support it. Preliminary CI runs show this will be a very low effort. But we will not go into the analysis until our team actually works on adding support for Node 22. Frankly, you shouldn't be using a Node.js version that isn't LTS so any other conversations are moot. |
Gotcha. Thank you for the explanation. |
Is your feature request related to a problem? Please describe.
Node 22 is not currently officially supported by Node-Newrelic, and is not included in CI matrix.
Feature Description
Fix whatever compatibilities with Node 22 there might be, make CI pass, include Node 22 in the CI matrix.
Priority
Please help us better understand this feature request by choosing a priority from the following options:
[Really Want]
The text was updated successfully, but these errors were encountered: