Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract common attributes necessary for tracking external segments/spans #2177

Closed
bizob2828 opened this issue Apr 30, 2024 · 1 comment · Fixed by #2179
Closed

Abstract common attributes necessary for tracking external segments/spans #2177

bizob2828 opened this issue Apr 30, 2024 · 1 comment · Fixed by #2179
Assignees
Labels
points: 5 1-2 weeks

Comments

@bizob2828
Copy link
Member

bizob2828 commented Apr 30, 2024

Description

In #2169 we discovered the logic for creating and assigning external segments/spans was cobbled together. We should provide convenience methods for capturing the necessary naming conventions for segments, and all of its necessary segment and span attributes.

Acceptance Criteria

As a Node.js engineer I should be able to call a convenience method to track an external http call as a segment with the appropriate attributes.

Additional Context

grpc instrumentation is in violation of what needs to be captured, this abstraction will help this out. undici and http-outbound are the other places external segments are captured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment