Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new span attributes to SQS calls to facilitate entity relationships #2377

Closed
bizob2828 opened this issue Jul 18, 2024 · 1 comment · Fixed by #2436
Closed

Add new span attributes to SQS calls to facilitate entity relationships #2377

bizob2828 opened this issue Jul 18, 2024 · 1 comment · Fixed by #2436
Assignees
Labels
points: 5 1-2 weeks

Comments

@bizob2828
Copy link
Member

bizob2828 commented Jul 18, 2024

Description

We need to add new span attributes so the cloud monitoring team can link SQS calls from Node.js app to AWS SQS:

Linking between APM and SQS entities is done using the following span attributes:

  • messaging.system - should be the string aws_sqs
  • cloud.region - the AWS region the queue is in. eg. us-east-2
  • cloud.account.id - the AWS' account id. eg. 123456789012
  • messaging.destination.name - the name of the queue. eg. MyQueue

cloud.region, cloud.account.id, and messaging.destination.name can be derived from the queue URL. The queue URL follow the format:

https://sqs.{region}.amazonaws.com/{account.id}/{queue.name}.

Additional context

I don't think these should go into the common attributes here but instead add an after hook to parse the QueueUrl and add the relevant span attributes described above.

@workato-integration
Copy link

@newrelic-node-agent-team newrelic-node-agent-team moved this to Triage Needed: Unprioritized Features in Node.js Engineering Board Jul 18, 2024
@bizob2828 bizob2828 added points: 5 1-2 weeks and removed needs-triage labels Jul 23, 2024
@kmudduluru kmudduluru moved this from Triage Needed: Unprioritized Features to To do: Features here are prioritized for this sprint (jira for remaining tickets) in Node.js Engineering Board Aug 1, 2024
@jsumners-nr jsumners-nr self-assigned this Aug 2, 2024
@jsumners-nr jsumners-nr moved this from To do: Features here are prioritized for this sprint (jira for remaining tickets) to In progress: Issues being worked on in Node.js Engineering Board Aug 2, 2024
@github-project-automation github-project-automation bot moved this from In progress: Issues being worked on to Done: Issues recently completed in Node.js Engineering Board Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
points: 5 1-2 weeks
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants