-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@aws-sdk/client-s3@3.616.0 fails to add aws.* attributes to the external span #2378
Comments
bizob2828
changed the title
aws mock doesn't work with @aws-sdk/client-s3@3.616.0+
Jul 19, 2024
@aws-sdk/client-s3
does not add aws.* attributes to the appropriate span
This is a bug but I have confirmed it is not a bug in instrumentation, just how we're mocking the aws server in versioned tests |
bizob2828
changed the title
aws mock doesn't work with @aws-sdk/client-s3@3.616.0+
@aws-sdk/client-s3@3.616.0 fails to add aws.* attributes to the external span
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
It looks like in
@aws-sdk/client-s3@3.616.0
our versioned tests stop working. The reason is because the context manager returns the root span in addAwsAttribute middleware. It looks like the root cause is https://github.com/aws/aws-sdk-js-v3/pull/6232/files. The response is getting wrapped in a stream and we rely on the IncomingMessage to get the external span.Expected Behavior
s3 client adds the aws.* to the appropriate span.
Steps to Reproduce
npm run versioned:internal:major aws-sdk-v3
The text was updated successfully, but these errors were encountered: