-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amqplib AWS Entity Relationships support #2388
Labels
points: 5
1-2 weeks
Comments
newrelic-node-agent-team
moved this to Triage Needed: Unprioritized Features
in Node.js Engineering Board
Jul 22, 2024
bizob2828
moved this from Triage Needed: Unprioritized Features
to In progress: Issues being worked on
in Node.js Engineering Board
Jul 22, 2024
bizob2828
moved this from In progress: Issues being worked on
to Triage Needed: Unprioritized Features
in Node.js Engineering Board
Jul 22, 2024
bizob2828
added
needs-triage
points: 5
1-2 weeks
and removed
points: 5
1-2 weeks
needs-triage
labels
Jul 22, 2024
bizob2828
moved this from Triage Needed: Unprioritized Features
to To do: Features here are prioritized for this sprint (jira for remaining tickets)
in Node.js Engineering Board
Jul 23, 2024
bizob2828
moved this from To do: Features here are prioritized for this sprint (jira for remaining tickets)
to In progress: Issues being worked on
in Node.js Engineering Board
Jul 24, 2024
bizob2828
moved this from In progress: Issues being worked on
to Needs PR Review
in Node.js Engineering Board
Jul 26, 2024
github-project-automation
bot
moved this from Needs PR Review
to Done: Issues recently completed
in Node.js Engineering Board
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
To properly link calls from Node.js application to AWS MQ the following must be present:
MessageBroker/{Library}/{DestinationType}/{Action}/Named/{DestinationName}
server.address
We already create a metric of that name but we do not assign
server.address
to rabbitmq spans.Acceptance Criteria
Calls to amqplib should produce:
MessageBroker/{Library}/{DestinationType}/{Action}/Named/{DestinationName}
metric andserver.address
span attribute.Additional context
We should add collecting host on all messaging-shim calls. Translate
attributes.hostname
toserver.address
in the SpanEvent. Since the other types also assignserver.address
, we should move this logic to SpanEvent and also includeserver.port
if they are presentThe text was updated successfully, but these errors were encountered: