Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kafkajs Node metric format #2457

Closed
bizob2828 opened this issue Aug 13, 2024 · 1 comment · Fixed by #2458
Closed

Fix kafkajs Node metric format #2457

bizob2828 opened this issue Aug 13, 2024 · 1 comment · Fixed by #2458
Assignees
@bizob2828
Labels
points: 3 A few days

Comments

@bizob2828
Copy link
Member

Description

We thought we were following the spec for the Kakfa node metrics but we added an extra /Named to the metric name. This was preventing the AWS entity relationship from properly linking

Acceptance Criteria

Create metrics for every consume or produce in the following format

MessageBroker/Kafka/Nodes/{server_name}/Produce/{topic_name} 
MessageBroker/Kafka/Nodes/{server_name}/Consume/{topic_name}
@bizob2828 bizob2828 self-assigned this Aug 13, 2024
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-302521

@bizob2828 bizob2828 added the points: 3 A few days label Aug 13, 2024
@newrelic-node-agent-team newrelic-node-agent-team moved this to Triage Needed: Unprioritized Features in Node.js Engineering Board Aug 13, 2024
@bizob2828 bizob2828 mentioned this issue Aug 13, 2024
Merged
@github-project-automation github-project-automation bot moved this from Triage Needed: Unprioritized Features to Done: Issues recently completed in Node.js Engineering Board Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bizob2828 bizob2828

Labels
points: 3 A few days
Projects
Node.js Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Updated the kafkajs node metrics to remove /Named from the name bizob2828/node-newrelic
1 participant
@bizob2828