Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert instances of fakeCollectorApi to use Collector instead #2592

Closed
amychisholm03 opened this issue Sep 19, 2024 · 1 comment · Fixed by #2669
Closed

Convert instances of fakeCollectorApi to use Collector instead #2592

amychisholm03 opened this issue Sep 19, 2024 · 1 comment · Fixed by #2669
Assignees
@jsumners-nr
Labels
points: 3 A few days

Comments

@amychisholm03
Copy link
Contributor

When reviewing #2585, we noticed that we are using fakeCollectorApi instead of the Collector class in test/lib/test-collector.js. We should look at the tests in test/unit and change them accordingly.

Files to change:

  • test/unit/transaction-event-aggregator.test.js
@amychisholm03 amychisholm03 converted this from a draft issue Sep 19, 2024
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-315388

@amychisholm03 amychisholm03 changed the title Convert instances of fakeCollectorApi to use Collector in test/lib/test-collector.js Convert instances of fakeCollectorApi to use Collector instead Sep 19, 2024
@amychisholm03 amychisholm03 mentioned this issue Sep 19, 2024
Merged
@bizob2828 bizob2828 added the points: 3 A few days label Oct 1, 2024
@jsumners-nr jsumners-nr self-assigned this Oct 21, 2024
@jsumners-nr jsumners-nr mentioned this issue Oct 21, 2024
Merged
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done: Issues recently completed in Node.js Engineering Board Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsumners-nr jsumners-nr

Labels
points: 3 A few days
Projects
Node.js Engineering Board
Status: Done: Issues recently completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Replaced usage of fake-collector with test-collector jsumners-nr/node-newrelic
3 participants
@bizob2828 @amychisholm03 @jsumners-nr