Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformations.add_attributes.attributes does not maintain case #364

Closed
jepries opened this issue Oct 26, 2022 · 2 comments
Closed

Transformations.add_attributes.attributes does not maintain case #364

jepries opened this issue Oct 26, 2022 · 2 comments
Labels
bug Categorizes issue or PR as related to a bug.

Comments

@jepries
Copy link

jepries commented Oct 26, 2022

Description

transformations:
  - description: "Transformation for UCS NR metrics"
    add_attributes:
      - prefix: ""
        attributes:
          namespace: "RELEASENAMESPACE"
          nrVSAD: "RELEASEVSAD"
          nrPOC:  "RELEASEPOC"
          nrPlatform: "RELEASEPLATFORM"
          nrENVT: "RELEASEENVIRONMENT" 
    rename_attributes:
      - metric_prefix: ""
        attributes:
          nrpoc:  "nrPOC"
          nrvsad: "nrVSAD"
          nrplatform: "nrPlatform"
          nrenvt: "nrENVT"

the above example is what I need to do in order to create a case sensitive dimension sent to New Relic metric.
What the above does is actually send 2 attributes, example "nrvsad" and "nrVSAD"

Expected Behavior

Maintain the case of the attribute as defined in Transformations.add_attributes.attributes

Troubleshooting or [NR Diag]

simply search the metrics you published in the new relic data browser, you will see Dimensions showing both the all lower case and the mixed case versions.

Steps to Reproduce

Add any metric you like to Transformations.add_attributes.attributes that has mixed case and observe how it is posted in a new relic data search under Dimensions.

Your Environment

Kubernetes, running 2.16.6 version of nri-prometheus

Additional context

none

For Maintainers Only or Hero Triaging this bug

Suggested Priority (P1,P2,P3,P4,P5):
Suggested T-Shirt size (S, M, L, XL, Unknown):

@jepries jepries added the bug Categorizes issue or PR as related to a bug. label Oct 26, 2022
@workato-integration
Copy link

@davidgit
Copy link
Contributor

davidgit commented Nov 4, 2022

We appreciate you taking the time to bring this to our attention. After reviewing this issue, we are unable to commit on a timeline to resolution. When committing to resolve an issue, we take into account the type of issue, the customer impact, and the development effort required. If the situation changes, we will revisit this decision.

In this particular case, we are using a a library which is not case sensitive and, as commented above, we don't plan to replace that tool in the short-term.

We encourage community contributions and are happy to collaborate on design proposals and pull requests. See our PR guidelines in the README. If you have any further questions or comments about this, please let us know by replying to this issue.

@davidgit davidgit closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants