Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #47

Open
cutler-scott-newrelic opened this issue Oct 28, 2022 · 4 comments
Open

Update dependencies #47

cutler-scott-newrelic opened this issue Oct 28, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@cutler-scott-newrelic
Copy link
Contributor

Summary

A lot of the dependencies are now majorly out of date, but simply changing the cargo.toml is not enough, a fair amount of code will need to be re-written to support the newer libraries.

Additional context

Updating libraries will support newer features and hopefully improve performance.

@cutler-scott-newrelic cutler-scott-newrelic added the enhancement New feature or request label Oct 28, 2022
@Coruscant11
Copy link

Coruscant11 commented Nov 28, 2022

Hello, I would like to work on this issue.
It will be my first time contributing to open source project, do you have any advice?
I will make a commit per dependency update, is it a good way?

I am using rusty hog at work (I am a computer science student and apprentice at Amadeus), I like it and want to help.

I would be happy to try to update it to gitoxide too, but I will try this issue first.
I forked the repo and I started to work on this issue and I will keep you updated.
Feel free to share any advice!
Thanks

@cutler-scott-newrelic
Copy link
Contributor Author

Hi Coruscant, thanks for the offer! I would definitely recommend to start with one package at a time, and avoid a few of the more problematic packages by focusing on the best maintained ones like Clap

@cutler-scott-newrelic
Copy link
Contributor Author

Also, avoiding the packages that are actually making network calls will probably help keep things simple

@Coruscant11
Copy link

Okay! I will try to start with clap then. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants