[WIP] Add OIDC via mozilla-django-oidc #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different way of logging in. Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
|
@aalexanderr we had discussed this as being a bit too specific for inclusion in the default ScanCode.io. I am closing this for now, but I wonder if we could revive it by packaging this as an external "plugin" of sorts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something we use at scancode.onap.eu
mozilla-django-oidc is a minimal lib and does not implement stuff like:
this solution creates a user with preferred_username as username which might not be unique
by default (mozilla-django-oidc) username is a hash of e-mail (im not 100% sure but its not important)
I'm currently testing different solutions (django-allauth, python social login) that would handle above but thought to submit this as a follow up to #336 as we are currently using it