-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around PosgreSQL index issue #653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work, but IMHO we need first a minimal test case that reproduces the error.
b5b1ab4
to
cbec211
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
You may be missing one migration though and this should be a data migration that computes the md5 for the actual data?
When I run |
Why do we have three fields in the model (summary_md5, package affected_md5, references_md5) separately. IMHO we can have one field and hash all the fields inside it. This will help us not to store useless data in the database
|
83506ae
to
0d4419d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
See a few comments for you consideration!
55cde35
to
de19f98
Compare
Work around PostgreSQL index issue Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
de19f98
to
e6f12d5
Compare
Update model to use an index on a checksum of the large summary text field.
Otherwise there can be times when this exceeds PostgreSQL limits.
See #632 (comment)
The failing test before this patch #659
Reference: #650
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com